Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [cherry-pick] failed to release collection with more than 128 partitions #28567

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: [cherry-pick] failed to release collection with more than 128 partitions #28567

merged 1 commit into from
Nov 22, 2023

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented Nov 20, 2023 •
edited
Loading

issue: #28343
pr: #28446

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 20, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023

@wayblink Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label Nov 20, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Merging #28567 (ddf6023) into 2.3 (1383680) will increase coverage by 0.02%.
Report is 6 commits behind head on 2.3.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #28567      +/-   ##
==========================================
+ Coverage   81.96%   81.98%   +0.02%     
==========================================
  Files         813      822       +9     
  Lines      117777   117815      +38     
==========================================
+ Hits        96534    96590      +56     
+ Misses      18033    18024       -9     
+ Partials     3210     3201       -9
Files Coverage Δ
internal/metastore/kv/querycoord/kv_catalog.go 64.40% <71.42%> (-0.84%) ⬇️

... and 162 files with indirect coverage changes

@wayblink
Copy link
Collaborator Author

/run-cpu-e2e

1 similar comment
@wayblink
Copy link
Collaborator Author

/run-cpu-e2e

@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 22, 2023
@sre-ci-robot sre-ci-robot merged commit a04b528 into milvus-io:2.3 Nov 22, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@jiaoew1991 jiaoew1991

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wayblink @jiaoew1991 @sre-ci-robot @yanliang567