fix: [2.3]parse logID from logPath if copyDeltalog find logID not provided #29276
Conversation
…vided Cherry-pick from master pr: milvus-io#29273 See also: milvus-io#29272 This PR add `getDeltaLogID` to safely return logID when Binlog struct has zero value logID. It parses logID from logPath if the format is valid. Otherwise, this function shall return error. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #29276 +/- ##
=======================================
Coverage 82.09% 82.09%
=======================================
Files 832 832
Lines 119324 119385 +61
=======================================
+ Hits 97964 98015 +51
- Misses 18136 18140 +4
- Partials 3224 3230 +6
|
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
1 similar comment
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-pick from master
pr: #29273
See also: #29272
This PR add
getDeltaLogIDto safely return logID when Binlog struct has zero value logID. It parses logID from logPath if the format is valid. Otherwise, this function shall return error.