Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the result merging of IVF_PQ IP #2953

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix the result merging of IVF_PQ IP #2953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ Please mark all change in change log and use the issue from GitHub
# Milvus 0.10.2 (TBD)

## Bug
- \#2890 Fix the wrong index size
- \#2890 Fix the index size caculation in cache
- \#2952 Fix the result merging of IVF_PQ IP

## Feature

Expand Down
5 changes: 2 additions & 3 deletions core/src/scheduler/task/SearchTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,8 @@ XSearchTask::XSearchTask(const std::shared_ptr<server::Context>& context, Segmen
: Task(TaskType::SearchTask, std::move(label)), context_(context), file_(file) {
if (file_) {
// distance -- value 0 means two vectors equal, ascending reduce, L2/HAMMING/JACCARD/TONIMOTO ...
// similarity -- infinity value means two vectors equal, descending reduce, IP
if (file_->metric_type_ == static_cast<int>(MetricType::IP) &&
file_->engine_type_ != static_cast<int>(EngineType::FAISS_PQ)) {
// similarity -- value 1 means two vectors equal, descending reduce, IP
if (file_->metric_type_ == static_cast<int>(MetricType::IP)) {
ascending_reduce = false;
}

Expand Down