Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.3] Add concurrency for datacoord segment GC #29557

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Dec 28, 2023

issue: #29553
pr: #29561
/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Dec 28, 2023
Copy link
Contributor

mergify bot commented Dec 28, 2023

@SimFG Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Dec 28, 2023
Copy link
Contributor

mergify bot commented Dec 28, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 28, 2023
@SimFG
Copy link
Contributor Author

SimFG commented Dec 28, 2023

pr: #29561

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67313cc) 82.16% compared to head (fc4a430) 82.15%.
Report is 8 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29557      +/-   ##
==========================================
- Coverage   82.16%   82.15%   -0.02%     
==========================================
  Files         833      833              
  Lines      119714   119742      +28     
==========================================
+ Hits        98361    98371      +10     
- Misses      18136    18146      +10     
- Partials     3217     3225       +8     
Files Coverage Δ
internal/datacoord/garbage_collector.go 90.88% <100.00%> (+3.03%) ⬆️
pkg/util/paramtable/component_param.go 98.28% <100.00%> (+<0.01%) ⬆️

... and 15 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 28, 2023
Signed-off-by: SimFG <bang.fu@zilliz.com>
Copy link
Contributor

mergify bot commented Dec 29, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 29, 2023

/run-cpu-e2e

1 similar comment
@SimFG
Copy link
Contributor Author

SimFG commented Jan 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jan 2, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 2, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a2365e4 into milvus-io:2.3 Jan 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants