Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Cherry-pick] throw exception when upload file failed for DiskIndex #29628

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Jan 2, 2024

Cherry pick from master
pr: #29627
related to: #29417

Signed-off-by: xianliang <xianliang.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 2, 2024
Copy link
Contributor

mergify bot commented Jan 2, 2024

@foxspy Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Jan 2, 2024

@foxspy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@foxspy foxspy changed the title fix : [Cherry-pick] throw exception when upload file failed for DiskIndex fix: [Cherry-pick] throw exception when upload file failed for DiskIndex Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a373be) 82.15% compared to head (6dc6351) 82.15%.
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #29628   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         833      824    -9     
  Lines      119723   119692   -31     
=======================================
- Hits        98355    98332   -23     
+ Misses      18149    18133   -16     
- Partials     3219     3227    +8     
Files Coverage Δ
internal/core/src/index/VectorDiskIndex.cpp 77.77% <66.66%> (+0.35%) ⬆️

... and 165 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jan 3, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 66c8465 into milvus-io:2.3 Jan 3, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants