Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Authorize users to query grant info of their roles #29747

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

czs007
Copy link
Contributor

@czs007 czs007 commented Jan 7, 2024

Once a role is granted to a user, the user should automatically possess the privilege information associated with that role.

issue: #29710

Once a role is granted to a user, the user should automatically
possess the privilege information associated with that role.

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. area/test sig/testing labels Jan 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 7, 2024
Copy link
Contributor

mergify bot commented Jan 7, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented Jan 7, 2024

/run-cpu-e2e

@SimFG
Copy link
Contributor

SimFG commented Jan 8, 2024

/lgtm

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 660 lines in your changes are missing coverage. Please review.

Comparison is base (5be9099) 80.36% compared to head (93ce085) 80.10%.
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29747      +/-   ##
==========================================
- Coverage   80.36%   80.10%   -0.26%     
==========================================
  Files         931      934       +3     
  Lines      128508   129663    +1155     
==========================================
+ Hits       103272   103866     +594     
- Misses      21842    22350     +508     
- Partials     3394     3447      +53     
Files Coverage Δ
internal/core/src/exec/expression/CompareExpr.h 97.87% <100.00%> (+0.14%) ⬆️
...ternal/core/src/query/visitors/ExecExprVisitor.cpp 7.86% <ø> (+0.02%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 78.80% <100.00%> (+0.08%) ⬆️
internal/metastore/model/field.go 100.00% <100.00%> (ø)
internal/proxy/task.go 85.74% <100.00%> (+0.25%) ⬆️
pkg/util/merr/errors.go 85.71% <ø> (ø)
pkg/util/merr/utils.go 87.21% <100.00%> (+0.14%) ⬆️
internal/core/src/index/InvertedIndexTantivy.cpp 89.09% <87.50%> (-0.17%) ⬇️
internal/core/src/index/VectorDiskIndex.cpp 81.14% <66.66%> (-0.28%) ⬇️
internal/core/src/simd/sse4.cpp 0.00% <0.00%> (ø)
... and 11 more

... and 16 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit 7e6f73a into milvus-io:master Jan 8, 2024
13 of 14 checks passed
czs007 added a commit to czs007/milvus that referenced this pull request Jan 8, 2024
…9747)

Once a role is granted to a user, the user should automatically possess
the privilege information associated with that role.

issue: milvus-io#29710

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jan 8, 2024
…9762)

Once a role is granted to a user, the user should automatically possess
the privilege information associated with that role.

issue: #29710
pr: #29747

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants