fix: [cherry-pick]Save lite WatchInfo into etcd in DataNode #29751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: milvus-io#29689 pr: milvus-io#29687 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
mergify
bot
added
dco-passed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #29751 +/- ##
==========================================
+ Coverage 82.13% 82.15% +0.01%
==========================================
Files 832 832
Lines 119812 119827 +15
==========================================
+ Hits 98403 98438 +35
+ Misses 18192 18176 -16
+ Partials 3217 3213 -4
|
|
@XuanYang-cn E2e jenkins job failed, comment |
|
rerun ur |
|
rerun ut |
|
/run-cpu-e2e |
1 task
XuanYang-cn
added a commit
to XuanYang-cn/milvus
that referenced
this pull request
Jan 10, 2024
To watch a channel, datanode needs all segments info in the channel. The segmentIDs are notified through etcd meta datapb.ChannelWatchInfo. With the limitation of etcd meta is 2MB, the maxmaum segment number(int64) is around 200K. However DataNode will write full segmentInfo into etcd meta, which makes the limitmation even lesser, approximately **4k**. There's an ongoing pr to solve this issue: milvus-io#29751, milvus-io#29687. After these two PRs, we're expecting a limitation of **200K** segments. To make DataCoord&DataNode able to handle more segments, This PR introduces a Stream rpc: `ListChannelSegmentInfo(ChannelSegmentInfoRequest) returns(stream SegmentInfo)` The client would receive segmentInfo of a channel one by one, and has no limit for segment count in theory. See also: milvus-io#29861 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #29689
pr: #29687