Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support general capacity restrict for cloud-side resoure contro… #30017

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

MrPresent-Han
Copy link
Contributor

related: #29844
pr: ##29845

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dbc2ab) 82.22% compared to head (e4ad204) 82.73%.
Report is 22 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30017      +/-   ##
==========================================
+ Coverage   82.22%   82.73%   +0.51%     
==========================================
  Files         834      837       +3     
  Lines      120365   122538    +2173     
==========================================
+ Hits        98965   101378    +2413     
+ Misses      18183    17945     -238     
+ Partials     3217     3215       -2     
Files Coverage Δ
internal/rootcoord/constrant.go 100.00% <100.00%> (ø)
internal/rootcoord/create_collection_task.go 93.45% <100.00%> (+0.04%) ⬆️
internal/rootcoord/create_partition_task.go 100.00% <100.00%> (ø)
pkg/util/merr/errors.go 91.07% <ø> (ø)
pkg/util/merr/utils.go 88.96% <100.00%> (+0.12%) ⬆️
pkg/util/paramtable/component_param.go 99.60% <100.00%> (+1.29%) ⬆️

... and 47 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 16, 2024
@MrPresent-Han MrPresent-Han reopened this Jan 22, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 22, 2024
@czs007
Copy link
Contributor

czs007 commented Jan 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6aaccdd into milvus-io:2.3 Jan 22, 2024
24 checks passed
@yanliang567 yanliang567 added this to the 2.3.6 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants