Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [cherry-pick] fix otel config param type & leak #30068

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

congqixia
Copy link
Contributor

cherry pick from master
pr: #29810 #30055

SampleFraction shall be float and all C.CString shall be freed

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jan 17, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jan 17, 2024
Copy link
Contributor

mergify bot commented Jan 17, 2024

@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jan 17, 2024
SampleFraction shall be float and all C.CString shall be freed

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jan 17, 2024
Copy link
Contributor

mergify bot commented Jan 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9aceff5) 82.14% compared to head (674f259) 82.21%.
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30068      +/-   ##
==========================================
+ Coverage   82.14%   82.21%   +0.07%     
==========================================
  Files         834      825       -9     
  Lines      120991   120345     -646     
==========================================
- Hits        99387    98945     -442     
+ Misses      18382    18176     -206     
- Partials     3222     3224       +2     
Files Coverage Δ
internal/util/initcore/init_core.go 86.51% <100.00%> (+1.51%) ⬆️

... and 124 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2024
@yah01
Copy link
Member

yah01 commented Jan 18, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 14aa20b into milvus-io:2.3 Jan 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants