-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [cherry-pick] fix otel config param type & leak #30068
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
SampleFraction shall be float and all C.CString shall be freed Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #30068 +/- ##
==========================================
+ Coverage 82.14% 82.21% +0.07%
==========================================
Files 834 825 -9
Lines 120991 120345 -646
==========================================
- Hits 99387 98945 -442
+ Misses 18382 18176 -206
- Partials 3222 3224 +2
|
/lgtm |
cherry pick from master
pr: #29810 #30055
SampleFraction
shall be float and allC.CString
shall be freed