Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick] Shuffle candidates before channel assignment (#30066) #30089

Merged
merged 1 commit into from Jan 19, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #30066

Shuffle candidates to reduce scenario that some channel allocated into same node

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 18, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f6a19c) 82.18% compared to head (bfb5c6c) 82.20%.
Report is 9 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30089      +/-   ##
==========================================
+ Coverage   82.18%   82.20%   +0.01%     
==========================================
  Files         825      834       +9     
  Lines      120336   120396      +60     
==========================================
+ Hits        98901    98972      +71     
+ Misses      18207    18199       -8     
+ Partials     3228     3225       -3     
Files Coverage Δ
internal/distributed/proxy/httpserver/utils.go 85.61% <100.00%> (+0.82%) ⬆️
...al/querycoordv2/balance/rowcount_based_balancer.go 97.63% <100.00%> (+<0.01%) ⬆️

... and 165 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 18, 2024
@yah01
Copy link
Member

yah01 commented Jan 19, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 079ddbf into milvus-io:2.3 Jan 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants