Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use channel cp as the dml&start position for import segments (#30107) #30133

Merged

Conversation

bigsheeper
Copy link
Contributor

This PR discontinuing the subscription to the mq and, instead, employing the channel checkpoint as the DML and starting position for the import segments.

issue: #30106

pr: #30107

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 19, 2024
Copy link
Contributor

mergify bot commented Jan 19, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (079ddbf) 82.22% compared to head (fdfa873) 82.23%.
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #30133   +/-   ##
=======================================
  Coverage   82.22%   82.23%           
=======================================
  Files         836      836           
  Lines      120655   120634   -21     
=======================================
- Hits        99213    99201   -12     
+ Misses      18201    18198    -3     
+ Partials     3241     3235    -6     
Files Coverage Δ
internal/datanode/services.go 82.85% <100.00%> (+1.40%) ⬆️
internal/datacoord/services.go 85.73% <58.33%> (-0.31%) ⬇️

... and 10 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented Jan 22, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Contributor

czs007 commented Jan 22, 2024

/lgtm

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 22, 2024
@sre-ci-robot sre-ci-robot merged commit 917a4d7 into milvus-io:2.3 Jan 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants