Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support etcd authentication #30226

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

PowderLi
Copy link
Contributor

issue: #28895
add 3 configuration for ETCD config

Signed-off-by: PowderLi <min.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (4637659) 83.19% compared to head (0ebff01) 83.14%.
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30226      +/-   ##
==========================================
- Coverage   83.19%   83.14%   -0.05%     
==========================================
  Files         701      701              
  Lines      113124   113209      +85     
==========================================
+ Hits        94108    94131      +23     
- Misses      15405    15450      +45     
- Partials     3611     3628      +17     
Files Coverage Δ
internal/distributed/datacoord/service.go 87.85% <100.00%> (+0.14%) ⬆️
internal/distributed/datanode/service.go 79.38% <100.00%> (+0.27%) ⬆️
internal/distributed/indexnode/service.go 71.34% <100.00%> (-1.96%) ⬇️
internal/distributed/proxy/service.go 82.91% <100.00%> (-0.60%) ⬇️
internal/distributed/querycoord/service.go 74.67% <100.00%> (+0.33%) ⬆️
internal/distributed/querynode/service.go 80.48% <100.00%> (+0.28%) ⬆️
internal/distributed/rootcoord/service.go 80.07% <100.00%> (+0.21%) ⬆️
internal/kv/etcd/metakv_factory.go 70.73% <100.00%> (+2.31%) ⬆️
internal/util/dependency/kv/kv_client_handler.go 89.18% <100.00%> (+0.95%) ⬆️
pkg/config/etcd_source.go 81.05% <100.00%> (+11.57%) ⬆️
... and 5 more

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 23, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PowderLi, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 08ca0a2 into milvus-io:master Jan 24, 2024
14 checks passed
@PowderLi PowderLi deleted the master-etcd-authentication branch April 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants