Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.3] Utilize partition key optimization in reQuery #30255

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

congqixia
Copy link
Contributor

Partial cherry-pick from master due to code branching
pr: #30253
See also #30250

This PR add requery flag in query task. When reQuery flag is true, query task shall skip partition name conversion and use pre-calculated partitionIDs passed from search task.

See also milvus-io#30250

This PR add requery flag in query task. When reQuery flag is true, query task shall skip partition name conversion and use pre-calculated partitionIDs passed from search task.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 24, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (95cd6f2) 82.11% compared to head (8b806ce) 82.09%.
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30255      +/-   ##
==========================================
- Coverage   82.11%   82.09%   -0.02%     
==========================================
  Files         841      841              
  Lines      121074   121077       +3     
==========================================
- Hits        99414    99395      -19     
- Misses      18416    18435      +19     
- Partials     3244     3247       +3     
Files Coverage Δ
internal/proxy/task_search.go 77.37% <100.00%> (+0.06%) ⬆️
internal/proxy/task_query.go 78.90% <21.42%> (+0.04%) ⬆️

... and 12 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 24, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 24, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

3 similar comments
@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 24, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 25, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@yah01
Copy link
Member

yah01 commented Jan 25, 2024

/lgtm

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 25, 2024
@sre-ci-robot sre-ci-robot merged commit e3114b6 into milvus-io:2.3 Jan 25, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants