Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick] Opt vector dimension mismatch error message #30316

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 26, 2024

Cherry-pick from master
pr: #29928

Signed-off-by: xige-16 xi.ge@zilliz.com

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 26, 2024
Copy link
Contributor

mergify bot commented Jan 26, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Jan 26, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 26, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Jan 26, 2024

/run-cpu-e2e

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (650dcc5) 82.05% compared to head (8334b86) 82.09%.
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30316      +/-   ##
==========================================
+ Coverage   82.05%   82.09%   +0.03%     
==========================================
  Files         840      840              
  Lines      121141   121174      +33     
==========================================
+ Hits        99401    99475      +74     
+ Misses      18496    18454      -42     
- Partials     3244     3245       +1     
Files Coverage Δ
internal/core/src/common/EasyAssert.h 84.21% <ø> (ø)
internal/distributed/datacoord/service.go 87.75% <100.00%> (+0.15%) ⬆️
internal/distributed/datanode/service.go 82.19% <100.00%> (+0.33%) ⬆️
internal/distributed/indexnode/service.go 71.51% <100.00%> (+0.70%) ⬆️
internal/distributed/proxy/service.go 81.10% <100.00%> (+0.73%) ⬆️
internal/distributed/querycoord/service.go 73.87% <100.00%> (+0.23%) ⬆️
internal/distributed/querynode/service.go 80.58% <100.00%> (+0.38%) ⬆️
internal/distributed/rootcoord/service.go 79.43% <100.00%> (+0.29%) ⬆️
pkg/util/paramtable/component_param.go 98.37% <100.00%> (+0.03%) ⬆️
internal/datacoord/server.go 71.02% <91.66%> (+1.14%) ⬆️
... and 7 more

... and 7 files with indirect coverage changes

@xige-16
Copy link
Contributor Author

xige-16 commented Jan 26, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 26, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 29, 2024
@yah01
Copy link
Member

yah01 commented Jan 29, 2024

/lgtm

@czs007
Copy link
Contributor

czs007 commented Jan 29, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9ab2ce0 into milvus-io:2.3 Jan 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants