Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't not get search_cache_budget_gb in create index #30353

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Jan 30, 2024

issue:#30375
pr: #30119

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 30, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jan 30, 2024
Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Jan 30, 2024
Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (df2dc76) 82.09% compared to head (52b28b3) 82.11%.
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30353      +/-   ##
==========================================
+ Coverage   82.09%   82.11%   +0.02%     
==========================================
  Files         841      841              
  Lines      121197   121219      +22     
==========================================
+ Hits        99493    99537      +44     
+ Misses      18456    18441      -15     
+ Partials     3248     3241       -7     
Files Coverage Δ
pkg/util/indexparams/index_params.go 87.75% <100.00%> (+1.20%) ⬆️
internal/datacoord/index_builder.go 89.96% <0.00%> (ø)

... and 11 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 30, 2024
Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Collaborator

foxspy commented Jan 30, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Jan 30, 2024

/approve

@foxspy
Copy link
Collaborator

foxspy commented Jan 30, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jan 30, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 31, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Collaborator

foxspy commented Jan 31, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 31, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Collaborator

foxspy commented Jan 31, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 31, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Collaborator

foxspy commented Jan 31, 2024

/run-cpu-e2e

1 similar comment
@foxspy
Copy link
Collaborator

foxspy commented Jan 31, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 31, 2024
@czs007
Copy link
Contributor

czs007 commented Jan 31, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3036c19 into milvus-io:2.3 Jan 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants