enhance: limit the max pool size to 16 #30371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@yah01 E2e jenkins job failed, comment |
according to our benchmark, concurrency level 16 is enough to fully utilize the object storage network bandwidth Signed-off-by: yah01 <yang.cen@zilliz.com>
yah01
force-pushed
the
limit-pool-size
branch
from
adca68a
to
c7e30c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30371 +/- ##
==========================================
+ Coverage 79.83% 83.25% +3.42%
==========================================
Files 954 707 -247
Lines 134860 114892 -19968
==========================================
- Hits 107660 95649 -12011
+ Misses 23538 15579 -7959
- Partials 3662 3664 +2
|
yanliang567
added
ci-passed
manual-pass
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yah01
added a commit
to yah01/milvus
that referenced
this pull request
Jan 31, 2024
according to our benchmark, concurrency level 16 is enough to fully utilize the object storage network bandwidth Signed-off-by: yah01 <yang.cen@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Feb 20, 2024
czs007
added a commit
to czs007/milvus
that referenced
this pull request
Feb 23, 2024
Revert "enhance: reduce many I/O operations while loading disk index (milvus-io#30189) (milvus-io#30690)" This reverts commit d4c4bf9. Revert "enhance: limit the max pool size to 16 (milvus-io#30371) (milvus-io#30415)" This reverts commit 52ac071. Revert "enhance: convert the `GetObject` util to async (milvus-io#30166) (milvus-io#30197)" This reverts commit 4b7c5ba. Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
yanliang567
pushed a commit
that referenced
this pull request
Feb 24, 2024
Revert "enhance: reduce many I/O operations while loading disk index (#30189) (#30690)" This reverts commit d4c4bf9. Revert "enhance: limit the max pool size to 16 (#30371) (#30415)" This reverts commit 52ac071. Revert "enhance: convert the `GetObject` util to async (#30166) (#30197)" This reverts commit 4b7c5ba. Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
MrPresent-Han
added a commit
to MrPresent-Han/milvus
that referenced
this pull request
Mar 19, 2024
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
wayblink
pushed a commit
to wayblink/milvus
that referenced
this pull request
Mar 20, 2024
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
MrPresent-Han
added a commit
to MrPresent-Han/milvus
that referenced
this pull request
Mar 21, 2024
Signed-off-by: MrPresent-Han <chun.han@zilliz.com> add vchannel to stats path
MrPresent-Han
added a commit
to MrPresent-Han/milvus
that referenced
this pull request
Mar 21, 2024
Signed-off-by: MrPresent-Han <chun.han@zilliz.com> add vchannel to stats path
MrPresent-Han
added a commit
to MrPresent-Han/milvus
that referenced
this pull request
Mar 21, 2024
Signed-off-by: MrPresent-Han <chun.han@zilliz.com> add vchannel to stats path
MrPresent-Han
added a commit
to MrPresent-Han/milvus
that referenced
this pull request
Mar 21, 2024
Signed-off-by: MrPresent-Han <chun.han@zilliz.com> add vchannel to stats path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to our benchmark, concurrency level 16 is enough to fully utilize the object storage network bandwidth