Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [skip e2e] set logrus log level to reduce output error logs #30478

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Feb 2, 2024

issue: #30295
pr: #30478

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 2, 2024
Copy link
Contributor

mergify bot commented Feb 2, 2024

@jaime0815 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f50799b) 82.11% compared to head (56e58a3) 82.12%.
Report is 7 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30478      +/-   ##
==========================================
+ Coverage   82.11%   82.12%   +0.01%     
==========================================
  Files         841      841              
  Lines      121261   121262       +1     
==========================================
+ Hits        99579    99592      +13     
+ Misses      18436    18432       -4     
+ Partials     3246     3238       -8     
Files Coverage Δ
pkg/util/hardware/mem_info.go 53.84% <100.00%> (+3.84%) ⬆️

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 2, 2024
@czs007
Copy link
Contributor

czs007 commented Feb 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7e7722e into milvus-io:2.3 Feb 4, 2024
13 checks passed
@jaime0815 jaime0815 deleted the cgourps-log-refine branch February 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants