Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Sparse Float Vector] add sparse vector support to milvus components #30630

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat: [Sparse Float Vector] add sparse vector support to milvus components #30630

merged 2 commits into from
Mar 13, 2024

Conversation

zhengbuqian
Copy link
Collaborator

@zhengbuqian zhengbuqian commented Feb 18, 2024 •
edited
Loading

add sparse float vector support to different milvus components, including proxy, data node to receive and write sparse float vectors to binlog, query node to handle search requests, index node to build index for sparse float column, etc.

#29419

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Feb 18, 2024
@zhengbuqian zhengbuqian mentioned this pull request Feb 18, 2024
Open
1 task
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian zhengbuqian mentioned this pull request Feb 21, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian zhengbuqian mentioned this pull request Mar 6, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@xiaofan-luan
Copy link
Contributor

Hooray! we just wait until all ut fixed before we merged

@zhengbuqian
Copy link
Collaborator Author

/hold

@sre-ci-robot sre-ci-robot removed the lgtm label Mar 13, 2024
@zhengbuqian
Copy link
Collaborator Author

/unhold

#30629 has been merged and I have rebased this PR onto master, this PR now contains only 1 commit and is ready to merge.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@zhengbuqian
[Sparse Float Vector] add sparse float vector support to different
2e506f0 
milvus components, including proxy, data node to receive and write
sparse float vectors to binlog, query node to handle search requests,
index node to build index for sparse float column, etc.

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.91476% with 188 lines in your changes are missing coverage. Please review.

Project coverage is 81.01%. Comparing base (1d96239) to head (15af5ce).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30630      +/-   ##
==========================================
+ Coverage   80.97%   81.01%   +0.03%     
==========================================
  Files         975      978       +3     
  Lines      142177   142775     +598     
==========================================
+ Hits       115130   115667     +537     
- Misses      23185    23239      +54     
- Partials     3862     3869       +7
Files Coverage Δ
internal/datacoord/compaction_trigger.go 83.17% <100.00%> (ø)
internal/datanode/compactor.go 88.38% <100.00%> (+0.84%) ⬆️
internal/parser/planparserv2/plan_parser_v2.go 89.30% <100.00%> (+0.13%) ⬆️
internal/proxy/task.go 85.38% <ø> (+0.20%) ⬆️
internal/storage/binlog_writer.go 81.34% <100.00%> (ø)
internal/storage/data_sorter.go 89.10% <100.00%> (+0.33%) ⬆️
internal/storage/event_writer.go 79.09% <100.00%> (ø)
internal/storage/stats.go 70.76% <100.00%> (ø)
pkg/util/funcutil/func.go 89.21% <100.00%> (+0.08%) ⬆️
pkg/util/gc/gc_tuner.go 68.67% <100.00%> (ø)
... and 23 more

... and 58 files with indirect coverage changes

@zhengbuqian
Copy link
Collaborator Author

/hold

@zhengbuqian zhengbuqian force-pushed the sparse-v7-pr3-official branch 2 times, most recently from 3d5a52c to 817c7f3 Compare March 13, 2024 14:18
@zhengbuqian
Copy link
Collaborator Author

/unhold

added some test coverage in a new standalone commit. let's see how that works out.

@zhengbuqian
sparse: update sparse related tests. not testing sparse vectors
15af5ce 
in golang tests that uses indexcgowrapper/dataset.go to build index,

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan xiaofan-luan merged commit 3c80083 into milvus-io:master Mar 13, 2024
12 of 14 checks passed
@zhengbuqian zhengbuqian deleted the sparse-v7-pr3-official branch March 13, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved area/compilation dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhengbuqian @xiaofan-luan @sre-ci-robot