Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make datacoord client retry on index api #30656

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

weiliu1031
Copy link
Contributor

pr: #30654

This PR add retry on all interface which belong to indexcoord in milvus 2.2 and. move to data coord in milvus 2.3, to prevent meet unimplemented error during rolling upgrade from milvus 2.2 to 2.3.

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Feb 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 19, 2024
Copy link
Contributor

mergify bot commented Feb 19, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Copy link
Contributor

mergify bot commented Feb 21, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.15%. Comparing base (31f33f6) to head (fa11837).
Report is 29 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30656      +/-   ##
==========================================
+ Coverage   82.11%   82.15%   +0.04%     
==========================================
  Files         841      841              
  Lines      121390   121480      +90     
==========================================
+ Hits        99677    99802     +125     
+ Misses      18468    18435      -33     
+ Partials     3245     3243       -2     
Files Coverage Δ
internal/distributed/datacoord/client/client.go 96.90% <100.00%> (+0.80%) ⬆️
internal/util/grpcclient/client.go 82.24% <100.00%> (-0.13%) ⬇️

... and 18 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 21, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 22, 2024
@czs007 czs007 added this to the 2.3.11 milestone Mar 4, 2024
@czs007
Copy link
Contributor

czs007 commented Mar 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit af54c3b into milvus-io:2.3 Mar 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants