Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong context passing into NewClient, error handling lost in session_util #30818

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Feb 26, 2024

issue: #30799
pr: #30817

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.15%. Comparing base (2896f5e) to head (69af00f).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30818      +/-   ##
==========================================
+ Coverage   82.11%   82.15%   +0.03%     
==========================================
  Files         841      841              
  Lines      122006   121402     -604     
==========================================
- Hits       100190    99739     -451     
+ Misses      18588    18423     -165     
- Partials     3228     3240      +12     
Files Coverage Δ
internal/util/grpcclient/client.go 84.21% <100.00%> (+0.26%) ⬆️
internal/querynodev2/server.go 72.09% <0.00%> (ø)

... and 112 files with indirect coverage changes

@chyezh chyezh force-pushed the fixup_distribution_is_not_servcieable_2_3 branch from 18bed40 to a6ead10 Compare February 26, 2024 07:42
@chyezh
Copy link
Contributor Author

chyezh commented Feb 26, 2024

rerun ut

…sion_util

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fixup_distribution_is_not_servcieable_2_3 branch from a6ead10 to f5d28e7 Compare February 26, 2024 13:51
Copy link
Contributor

mergify bot commented Feb 26, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

…sion_util

Signed-off-by: chyezh <chyezh@outlook.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 27, 2024
Copy link
Contributor

mergify bot commented Feb 27, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 27, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 27, 2024
@jaime0815
Copy link
Contributor

/lgtm

@xiaofan-luan
Copy link
Contributor

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1c8d9fa into milvus-io:2.3 Feb 28, 2024
14 checks passed
@chyezh chyezh deleted the fixup_distribution_is_not_servcieable_2_3 branch February 28, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants