Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clean kafka default configuration #30925

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: Clean kafka default configuration #30925

merged 1 commit into from
Mar 1, 2024

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented Feb 29, 2024 •
edited
Loading

issue: #30917
pr: #30924

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 29, 2024
@yhmo yhmo changed the title Clean kafka default configuration fix: Clean kafka default configuration Feb 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@yhmo Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/missing-related-pr labels Feb 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented Feb 29, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 29, 2024
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 29, 2024
@mergify mergify bot removed the ci-passed label Feb 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented Feb 29, 2024

/run-cpu-e2e

1 similar comment
@yhmo
Copy link
Contributor Author

yhmo commented Feb 29, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 1, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Clean kafka default configuration
08704e8 
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 1, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented Mar 1, 2024

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (483a32b) to head (08704e8).
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30925      +/-   ##
==========================================
+ Coverage   82.17%   82.18%   +0.01%     
==========================================
  Files         841      843       +2     
  Lines      121490   121529      +39     
==========================================
+ Hits        99833    99884      +51     
+ Misses      18424    18419       -5     
+ Partials     3233     3226       -7
Files Coverage Δ
pkg/util/paramtable/service_param.go 98.53% <100.00%> (ø)

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 1, 2024
congqixia
congqixia approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5b695d7 into milvus-io:2.3 Mar 1, 2024
14 checks passed
@yanliang567 yanliang567 added this to the 2.3.11 milestone Mar 4, 2024
@yhmo yhmo mentioned this pull request Mar 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
2.3.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yhmo @sre-ci-robot @congqixia @yanliang567