Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: starve lock caused by slow GetCompactionTo method when too much segments #30965

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Mar 1, 2024

issue: #30823
pr: #30963

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Mar 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 1, 2024
Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Mar 1, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Mar 1, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_slow_get_compaction_to_2_3 branch from 77c0291 to 1450855 Compare March 1, 2024 06:35
Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh chyezh force-pushed the fix_slow_get_compaction_to_2_3 branch from 1450855 to d769ba7 Compare March 1, 2024 07:37
Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh chyezh force-pushed the fix_slow_get_compaction_to_2_3 branch from d769ba7 to 3fd6fd3 Compare March 1, 2024 08:49
Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Mar 1, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_slow_get_compaction_to_2_3 branch 3 times, most recently from badef9b to edc3596 Compare March 3, 2024 13:14
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.22%. Comparing base (483a32b) to head (94c31b2).
Report is 13 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30965      +/-   ##
==========================================
+ Coverage   82.17%   82.22%   +0.04%     
==========================================
  Files         841      843       +2     
  Lines      121490   121873     +383     
==========================================
+ Hits        99833   100204     +371     
- Misses      18424    18440      +16     
+ Partials     3233     3229       -4     
Files Coverage Δ
internal/datacoord/meta.go 89.61% <100.00%> (+0.84%) ⬆️
internal/datacoord/segment_info.go 75.60% <96.77%> (+2.74%) ⬆️
internal/datacoord/services.go 85.88% <80.00%> (+0.03%) ⬆️

... and 40 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 3, 2024
@czs007 czs007 added this to the 2.3.11 milestone Mar 4, 2024
@xiaocai2333
Copy link
Contributor

/lgtm

…segments

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fix_slow_get_compaction_to_2_3 branch from edc3596 to 94c31b2 Compare March 4, 2024 11:32
@sre-ci-robot sre-ci-robot removed the lgtm label Mar 4, 2024
@mergify mergify bot removed the ci-passed label Mar 4, 2024
@czs007
Copy link
Contributor

czs007 commented Mar 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Mar 4, 2024
@sre-ci-robot sre-ci-robot merged commit df09222 into milvus-io:2.3 Mar 4, 2024
14 checks passed
@chyezh chyezh deleted the fix_slow_get_compaction_to_2_3 branch March 4, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants