Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] Clear DN unknown compaction tasks #30972

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

XuanYang-cn
Copy link
Contributor

If DC restarted, those unkonwn compaction tasks
will never get call back in DN, so that the segments in the compaction task will be locked, unable to sync and compaction again, blocking cp advance and compaction executing.

See also: #30137
pr: #30850

If DC restarted,  those unkonwn compaction tasks
will never get call back in DN, so that the segments in the compaction
task will be locked, unable to sync and compaction again, blocking cp
advance and compaction executing.

See also: milvus-io#30137
pr: milvus-io#30850

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 1, 2024
Copy link
Contributor

mergify bot commented Mar 1, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 93.15068% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (2896f5e) to head (e9d01c6).
Report is 25 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30972      +/-   ##
==========================================
+ Coverage   82.11%   82.18%   +0.06%     
==========================================
  Files         841      843       +2     
  Lines      122006   121557     -449     
==========================================
- Hits       100190    99900     -290     
+ Misses      18588    18428     -160     
- Partials     3228     3229       +1     
Files Coverage Δ
internal/datacoord/session_manager.go 82.57% <100.00%> (+0.07%) ⬆️
pkg/util/typeutil/pair.go 100.00% <100.00%> (ø)
internal/datanode/services.go 81.99% <83.33%> (-0.87%) ⬇️
internal/datacoord/compaction.go 94.85% <93.22%> (-0.84%) ⬇️

... and 122 files with indirect coverage changes

@czs007 czs007 added this to the 2.3.11 milestone Mar 4, 2024
@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 4, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bb2de0d into milvus-io:2.3 Mar 4, 2024
14 checks passed
@XuanYang-cn XuanYang-cn deleted the cherry-clear branch March 5, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants