-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [cherry-pick] Clear DN unknown compaction tasks #30972
Conversation
If DC restarted, those unkonwn compaction tasks will never get call back in DN, so that the segments in the compaction task will be locked, unable to sync and compaction again, blocking cp advance and compaction executing. See also: milvus-io#30137 pr: milvus-io#30850 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #30972 +/- ##
==========================================
+ Coverage 82.11% 82.18% +0.06%
==========================================
Files 841 843 +2
Lines 122006 121557 -449
==========================================
- Hits 100190 99900 -290
+ Misses 18588 18428 -160
- Partials 3228 3229 +1
|
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If DC restarted, those unkonwn compaction tasks
will never get call back in DN, so that the segments in the compaction task will be locked, unable to sync and compaction again, blocking cp advance and compaction executing.
See also: #30137
pr: #30850