Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: index meta use independent rather than global meta lock #30986

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #30837
pr: #30869

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 2, 2024
Copy link
Contributor

mergify bot commented Mar 2, 2024

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jaime0815 jaime0815 force-pushed the refine-segment-index-lock-23 branch from 2f862b1 to 3d13fc1 Compare March 2, 2024 14:17
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 95.38462% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (7014d35) to head (f4da411).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30986      +/-   ##
==========================================
+ Coverage   82.19%   82.21%   +0.01%     
==========================================
  Files         843      843              
  Lines      121847   121908      +61     
==========================================
+ Hits       100153   100225      +72     
+ Misses      18466    18451      -15     
- Partials     3228     3232       +4     
Files Coverage Δ
internal/datacoord/compaction_trigger.go 84.77% <100.00%> (+0.02%) ⬆️
internal/datacoord/garbage_collector.go 90.90% <100.00%> (ø)
internal/datacoord/segment_info.go 73.63% <100.00%> (+0.78%) ⬆️
internal/datacoord/server.go 70.30% <ø> (ø)
internal/datacoord/util.go 99.09% <100.00%> (ø)
internal/datacoord/index_service.go 95.14% <98.38%> (+0.27%) ⬆️
internal/datacoord/index_builder.go 89.96% <83.33%> (ø)
internal/datacoord/meta.go 88.64% <76.92%> (-0.47%) ⬇️
internal/datacoord/index_meta.go 98.54% <96.10%> (-0.73%) ⬇️

... and 18 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 2, 2024
@czs007 czs007 added this to the 2.3.11 milestone Mar 4, 2024
@jaime0815 jaime0815 force-pushed the refine-segment-index-lock-23 branch from 3d13fc1 to f9a684e Compare March 4, 2024 09:48
@mergify mergify bot removed the ci-passed label Mar 4, 2024
Copy link
Contributor

mergify bot commented Mar 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815 jaime0815 force-pushed the refine-segment-index-lock-23 branch from f9a684e to f4da411 Compare March 4, 2024 13:40
@mergify mergify bot added the ci-passed label Mar 4, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaime0815, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 336e0ae into milvus-io:2.3 Mar 5, 2024
14 checks passed
@jaime0815 jaime0815 deleted the refine-segment-index-lock-23 branch March 5, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants