Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix errors in the Index service APIs are ignored (#31077) #31086

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

bigsheeper
Copy link
Contributor

In Index service APIs, return error if occurs instead of always returning nil. Additionally, add more tests to cover this scenario.

issue: #31069, #31027

pr: #31077

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Mar 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 6, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@czs007
Copy link
Contributor

czs007 commented Mar 6, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added this to the 2.3.11 milestone Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (53f5a67) to head (afbe297).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31086      +/-   ##
==========================================
- Coverage   82.22%   82.21%   -0.01%     
==========================================
  Files         843      843              
  Lines      122047   122063      +16     
==========================================
+ Hits       100348   100354       +6     
- Misses      18466    18475       +9     
- Partials     3233     3234       +1     
Files Coverage Δ
internal/distributed/datacoord/client/client.go 96.96% <100.00%> (+0.05%) ⬆️
internal/querycoordv2/meta/coordinator_broker.go 93.08% <100.00%> (+0.30%) ⬆️

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 6, 2024
@sre-ci-robot sre-ci-robot merged commit 3eeeae8 into milvus-io:2.3 Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants