Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dirty sealed segment won't release after channel balance (#31095) #31126

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #31074
pr: #31095
This PR fix dirty sealed segment doesn't release after channel balance, dirty sealed segment means segment doesn't exist in targets.

…-io#31095)

issue: milvus-io#31074
This PR fix dirty sealed segment doesn't release after channel balance,
dirty sealed segment means segment doesn't exist in targets.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 7, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Mar 7, 2024
Copy link
Contributor

mergify bot commented Mar 7, 2024

@weiliu1031

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@weiliu1031 weiliu1031 changed the title [cherry-pick]fix: Dirty sealed segment won't release after channel balance (#31095) fix: Dirty sealed segment won't release after channel balance (#31095) Mar 7, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Mar 7, 2024
Copy link
Contributor

mergify bot commented Mar 7, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (3eeeae8) to head (a5abfb2).
Report is 8 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31126      +/-   ##
==========================================
+ Coverage   82.21%   82.23%   +0.01%     
==========================================
  Files         843      843              
  Lines      122063   122107      +44     
==========================================
+ Hits       100356   100412      +56     
+ Misses      18473    18469       -4     
+ Partials     3234     3226       -8     
Files Coverage Δ
internal/querycoordv2/checkers/segment_checker.go 85.01% <100.00%> (-0.85%) ⬇️

... and 16 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 7, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 855f71a into milvus-io:2.3 Mar 11, 2024
14 checks passed
@yanliang567 yanliang567 added this to the 2.3.12 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants