-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dirty sealed segment won't release after channel balance (#31095) #31126
fix: Dirty sealed segment won't release after channel balance (#31095) #31126
Conversation
…-io#31095) issue: milvus-io#31074 This PR fix dirty sealed segment doesn't release after channel balance, dirty sealed segment means segment doesn't exist in targets. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #31126 +/- ##
==========================================
+ Coverage 82.21% 82.23% +0.01%
==========================================
Files 843 843
Lines 122063 122107 +44
==========================================
+ Hits 100356 100412 +56
+ Misses 18473 18469 -4
+ Partials 3234 3226 -8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #31074
pr: #31095
This PR fix dirty sealed segment doesn't release after channel balance, dirty sealed segment means segment doesn't exist in targets.