Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Balance param use duplicated key (#31112) #31141

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Mar 8, 2024

pr: #31112
issue: #31115
This PR fix balance check interval param use duplicated key

issue: milvus-io#31115
This PR fix balance check interval  param use duplicated key

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 8, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Mar 8, 2024
Copy link
Contributor

mergify bot commented Mar 8, 2024

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (c37b779) to head (57cca02).
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #31141   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files         844      844           
  Lines      122167   122167           
=======================================
  Hits       100448   100448           
- Misses      18478    18484    +6     
+ Partials     3241     3235    -6     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.34% <100.00%> (ø)

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 8, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9d712f4 into milvus-io:2.3 Mar 11, 2024
14 checks passed
@yanliang567 yanliang567 added this to the 2.3.12 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants