-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix growing index data race and properly handle build error #31170
fix: fix growing index data race and properly handle build error #31170
Conversation
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
e55abad
to
74dc5ae
Compare
@zhengbuqian ut workflow job failed, comment |
74dc5ae
to
d8a8ef2
Compare
/unhold #30629 has been merged and I have rebased this PR onto master, this PR now contains only 1 commit and is ready to merge. |
…ing error Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
d8a8ef2
to
e52d2ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31170 +/- ##
==========================================
+ Coverage 80.97% 81.03% +0.05%
==========================================
Files 975 965 -10
Lines 142177 142423 +246
==========================================
+ Hits 115130 115408 +278
+ Misses 23185 23162 -23
+ Partials 3862 3853 -9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, foxspy, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #31169
also properly handling index build error by re-create a new index so that nothing will be left in the previous failed index build attempt.