Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix growing index data race and properly handle build error #31170

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

zhengbuqian
Copy link
Collaborator

@zhengbuqian zhengbuqian commented Mar 11, 2024

issue: #31169

also properly handling index build error by re-create a new index so that nothing will be left in the previous failed index build attempt.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Mar 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 11, 2024
@zhengbuqian
Copy link
Collaborator Author

/hold

Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

mergify bot commented Mar 11, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Mar 13, 2024
@zhengbuqian
Copy link
Collaborator Author

/unhold

#30629 has been merged and I have rebased this PR onto master, this PR now contains only 1 commit and is ready to merge.

…ing error

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.03%. Comparing base (1d96239) to head (e52d2ee).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31170      +/-   ##
==========================================
+ Coverage   80.97%   81.03%   +0.05%     
==========================================
  Files         975      965      -10     
  Lines      142177   142423     +246     
==========================================
+ Hits       115130   115408     +278     
+ Misses      23185    23162      -23     
+ Partials     3862     3853       -9     
Files Coverage Δ
internal/core/src/segcore/FieldIndexing.h 68.37% <ø> (+1.70%) ⬆️
internal/core/src/segcore/FieldIndexing.cpp 67.48% <83.33%> (-0.34%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.cpp 73.80% <85.71%> (-0.19%) ⬇️

... and 221 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 13, 2024
Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, foxspy, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7fc3094 into milvus-io:master Mar 13, 2024
14 checks passed
@zhengbuqian zhengbuqian deleted the sparse-v7-pr5-official branch March 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants