Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix data race on loadSealedSegmentFields opts #31230

Merged

Conversation

congqixia
Copy link
Contributor

See also #31229

See also milvus-io#31229

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Mar 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 13, 2024
Copy link
Contributor

mergify bot commented Mar 13, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (06b191b) to head (04d9af8).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31230      +/-   ##
==========================================
- Coverage   81.13%   81.08%   -0.05%     
==========================================
  Files         975      975              
  Lines      142206   142207       +1     
==========================================
- Hits       115373   115310      -63     
- Misses      22987    23043      +56     
- Partials     3846     3854       +8     
Files Coverage Δ
internal/querynodev2/segments/segment_loader.go 71.28% <100.00%> (+0.02%) ⬆️

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 13, 2024
@sunby
Copy link
Contributor

sunby commented Mar 14, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit b1ff8e2 into milvus-io:master Mar 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants