Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load operation when segment is on releasing #31340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: load operation when segment is on releasing #31340

wants to merge 1 commit into from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Mar 18, 2024

issue: #30857

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 18, 2024
This was referenced Mar 18, 2024
Closed
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited

Codecov Report

Attention: Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.27%. Comparing base (cfea3f4) to head (8342c05).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31340      +/-   ##
==========================================
- Coverage   81.75%   81.27%   -0.48%     
==========================================
  Files        1019     1029      +10     
  Lines      130732   132177    +1445     
==========================================
+ Hits       106876   107429     +553     
- Misses      19834    20705     +871     
- Partials     4022     4043      +21
Files Coverage Δ
internal/querynodev2/segments/segment_loader.go 73.14% <100.00%> (ø)
internal/querynodev2/segments/manager.go 78.34% <98.03%> (+1.77%) ⬆️

... and 35 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 18, 2024
@stale Stale
Copy link

stale bot commented Apr 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Apr 18, 2024
@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 89bd723 to c1c9a10 Compare April 25, 2024 11:19
@stale stale bot removed the stale indicates no udpates for 30 days label Apr 25, 2024
@mergify mergify bot removed the ci-passed label Apr 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 25, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 26, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 26, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 26, 2024

/run-cpu-e2e

2 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Apr 26, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Apr 28, 2024

/run-cpu-e2e

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from c1c9a10 to 82f918b Compare April 29, 2024 07:39
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 29, 2024

rerun ut

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Apr 29, 2024

rerun ut

@chyezh chyezh force-pushed the fix_load_when_release_happens branch 2 times, most recently from 76d3dee to 1daab1e Compare May 6, 2024 02:22
@chyezh chyezh mentioned this pull request May 6, 2024
Closed
@chyezh
Copy link
Contributor Author

chyezh commented May 6, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 6, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 1daab1e to 823b904 Compare May 6, 2024 13:55
@mergify Mergify
Copy link
Contributor

mergify bot commented May 6, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 823b904 to 0664cb3 Compare May 9, 2024 02:45
@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 0664cb3 to 6778d5f Compare May 9, 2024 06:22
@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented May 9, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented May 9, 2024

/run-cpu-e2e

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented May 9, 2024

/run-cpu-e2e

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 6778d5f to 5250479 Compare May 9, 2024 11:03
@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 5250479 to 8e74bdd Compare May 9, 2024 13:00
@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 8e74bdd to 3ec3242 Compare June 5, 2024 01:29
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 5, 2024

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot removed the dco-passed DCO check passed. label Jun 5, 2024
@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 3ec3242 to 22a9825 Compare June 5, 2024 01:35
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 5, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 22a9825 to 271d16f Compare June 5, 2024 01:43
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 5, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
fix: load operation when segment is on releasing
8342c05 
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 271d16f to 8342c05 Compare June 6, 2024 11:54
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. labels Jun 6, 2024
@chyezh chyezh mentioned this pull request Jun 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees
No one assigned
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chyezh @sre-ci-robot