Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load operation when segment is on releasing #31340

Merged
merged 2 commits into from
Jun 14, 2024
Merged

fix: load operation when segment is on releasing #31340

merged 2 commits into from
Jun 14, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Mar 18, 2024

issue: #30857

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 18, 2024
This was referenced Mar 18, 2024
Closed
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (9d4535c) to head (cf10ac0).
Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31340      +/-   ##
==========================================
- Coverage   80.91%   80.91%   -0.01%     
==========================================
  Files        1058     1058              
  Lines      135193   135425     +232     
==========================================
+ Hits       109397   109584     +187     
- Misses      21613    21650      +37     
- Partials     4183     4191       +8
Files Coverage Δ
internal/querynodev2/segments/segment_loader.go 73.33% <100.00%> (ø)
internal/querynodev2/segments/manager.go 77.62% <97.87%> (+1.60%) ⬆️

... and 49 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 18, 2024
@stale Stale
Copy link

stale bot commented Apr 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Apr 18, 2024
@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 89bd723 to c1c9a10 Compare April 25, 2024 11:19
@stale stale bot removed the stale indicates no udpates for 30 days label Apr 25, 2024
@mergify mergify bot removed the ci-passed label Apr 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 25, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 26, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 26, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 26, 2024

/run-cpu-e2e

2 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Apr 26, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Apr 28, 2024

/run-cpu-e2e

@chyezh chyezh force-pushed the fix_load_when_release_happens branch from c1c9a10 to 82f918b Compare April 29, 2024 07:39
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 29, 2024

rerun ut

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Apr 29, 2024

rerun ut

@chyezh chyezh force-pushed the fix_load_when_release_happens branch 2 times, most recently from 76d3dee to 1daab1e Compare May 6, 2024 02:22
@chyezh chyezh mentioned this pull request May 6, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented May 6, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jun 13, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Jun 13, 2024

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jun 13, 2024

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jun 13, 2024

/run-cpu-e2e

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Jun 13, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Jun 13, 2024

rerun ut

@chyezh
fix: load operation when segment is on releasing
320d9d2 
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 9c1d1e2 to 1482e8d Compare June 13, 2024 09:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh
fix: use typeutil.UniqueSet but not map[int64]int
cf10ac0 
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fix_load_when_release_happens branch from 1482e8d to cf10ac0 Compare June 13, 2024 11:25
@mergify mergify bot added the ci-passed label Jun 13, 2024
@weiliu1031
Copy link
Contributor

/lgtm

sre-ci-robot pushed a commit that referenced this pull request Jun 14, 2024
@chyezh
fix: load operation when segment is on releasing (#33699)
dd6c982 
issue: #30857
pr: #31340

---------

Signed-off-by: chyezh <chyezh@outlook.com>
@czs007
Copy link
Contributor

czs007 commented Jun 14, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9b69601 into milvus-io:master Jun 14, 2024
15 checks passed
@chyezh chyezh deleted the fix_load_when_release_happens branch June 14, 2024 07:52
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jun 26, 2024
@mergify mergify bot removed the ci-passed label Jun 26, 2024
@chyezh
Copy link
Contributor Author

chyezh commented Jun 26, 2024

Already picked into 2.4 by PR #33699.

@chyezh chyezh removed the PR | need cherry-pick need cherry pick to other branches label Jun 26, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@chyezh @yellow-shine
fix: load operation when segment is on releasing (milvus-io#31340)
3e5f44a 
issue: milvus-io#30857

---------

Signed-off-by: chyezh <chyezh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@czs007 czs007

@weiliu1031 weiliu1031

Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chyezh @weiliu1031 @czs007 @sre-ci-robot