-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wrong behavior of CurrentTargetFirst/NextTargetFirst in target manager(#31379) #31419
Conversation
…aanger (milvus-io#31379) issue: milvus-io#31162 when give scope CurrentTargetFirst/NextTargetFirst, it's expected to scan both current and next target. This PR fixed wrong behavior of CurrentTargetFirst/NextTargetFirst in target manager, which may cause unexpected task generated, and load collection may stuck forever due to dirty leader view. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #31419 +/- ##
==========================================
+ Coverage 82.23% 82.24% +0.01%
==========================================
Files 844 844
Lines 122286 122315 +29
==========================================
+ Hits 100557 100594 +37
+ Misses 18492 18488 -4
+ Partials 3237 3233 -4
|
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #31162
pr: #31379
when give scope CurrentTargetFirst/NextTargetFirst, it's expected to scan both current and next target.
This PR fixed wrong behavior of CurrentTargetFirst/NextTargetFirst in target manager, which may cause unexpected task generated, and load collection may stuck forever due to dirty leader view.