Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load segment task promote failed #31431

Merged

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Mar 20, 2024

issue: #30816
pr: #31430

pr #31319 introduce the logic that segment checker need to load level zero segment which only exist in current target.

This PR fix load segment task promote failed when segment only belongs to current target

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/M Denotes a PR that changes 30-99 lines. labels Mar 20, 2024
Copy link
Contributor

mergify bot commented Mar 20, 2024

@weiliu1031

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Mar 20, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 changed the title Fix load segment task promote failed24 fix: Load segment task promote failed Mar 20, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Mar 20, 2024
@czs007
Copy link
Contributor

czs007 commented Mar 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (5649b9a) to head (7790654).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31431      +/-   ##
==========================================
+ Coverage   81.08%   81.16%   +0.08%     
==========================================
  Files         980      980              
  Lines      143453   143453              
==========================================
+ Hits       116316   116433     +117     
+ Misses      23248    23133     -115     
+ Partials     3889     3887       -2     
Files Coverage Δ
internal/querycoordv2/task/scheduler.go 84.06% <100.00%> (+1.25%) ⬆️

... and 41 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 20, 2024
@sre-ci-robot sre-ci-robot merged commit 7abebf8 into milvus-io:2.4 Mar 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants