fix: Skip set node unreachable when get shard client failed (#31277) #31451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue: milvus-io#30531 cause get client from `shardClientMgr`, doesn't means query node is unavailable. because of the ref counter policy in `shardClientMgr`, which will clean the client, if no collection use qn as shard leader. This PR fix that set node unreachable when get shard client failed. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #31451 +/- ##
=======================================
Coverage 82.22% 82.22%
=======================================
Files 844 844
Lines 122291 122291
=======================================
+ Hits 100549 100557 +8
+ Misses 18507 18496 -11
- Partials 3235 3238 +3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weiliu1031
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #30531
pr: #31277
cause get client from
shardClientMgr, doesn't means query node is unavailable. because of the ref counter policy inshardClientMgr, which will clean the client, if no collection use qn as shard leader.This PR fix that set node unreachable when get shard client failed.