Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add some check fieldata dim to avoid error data input #31478

Merged
merged 1 commit into from Mar 25, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Mar 21, 2024

issue:#30138
pr: #31564

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 21, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Mar 21, 2024
Copy link
Contributor

mergify bot commented Mar 21, 2024

@cqy123456 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Mar 21, 2024

@cqy123456

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@cqy123456 cqy123456 changed the title add some check fieldata dim fix: add some check fieldata dim to avoid error data input Mar 21, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Mar 21, 2024
Copy link
Contributor

mergify bot commented Mar 21, 2024

@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Mar 21, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@cqy123456
Copy link
Contributor Author

rerun ut

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (7f201e8) to head (0457b54).
Report is 29 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31478      +/-   ##
==========================================
+ Coverage   81.09%   81.19%   +0.10%     
==========================================
  Files         980      980              
  Lines      143452   143579     +127     
==========================================
+ Hits       116328   116581     +253     
+ Misses      23243    23117     -126     
  Partials     3881     3881              
Files Coverage Δ
internal/proxy/validate_util.go 88.49% <100.00%> (+0.53%) ⬆️
pkg/util/funcutil/func.go 89.21% <100.00%> (ø)

... and 58 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Mar 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 17eb0c2 into milvus-io:2.4 Mar 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants