Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add max file num limit and max file size limit for import (#31497) #31542

Merged
merged 2 commits into from Mar 25, 2024

Conversation

bigsheeper
Copy link
Contributor

The max number of import files per request should not exceed 1024 by default (configurable).
The import file size allowed for importing should not exceed 16GB by default (configurable).

issue: #28521

pr: #31497

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 22, 2024
@bigsheeper
Copy link
Contributor Author

rerun ut

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.79%. Comparing base (9977454) to head (37a50f8).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31542      +/-   ##
==========================================
- Coverage   80.89%   80.79%   -0.11%     
==========================================
  Files         980      965      -15     
  Lines      143575   136584    -6991     
==========================================
- Hits       116150   110352    -5798     
+ Misses      23540    22519    -1021     
+ Partials     3885     3713     -172     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.35% <100.00%> (-0.03%) ⬇️
internal/datanode/importv2/util.go 63.12% <16.66%> (-1.62%) ⬇️
internal/proxy/impl.go 86.18% <0.00%> (-0.20%) ⬇️

... and 39 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Mar 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 25, 2024
@sre-ci-robot sre-ci-robot merged commit f1a108c into milvus-io:2.4 Mar 25, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants