New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [Cherry-pick] Custom bitset and bitset_view implementations #31592
Conversation
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com> (cherry picked from commit 5dcecc8)
@alexanderguzhva Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-cpu-e2e |
@alexanderguzhva E2e jenkins job failed, comment |
rerun ut |
/run-cpu-e2e |
@alexanderguzhva E2e jenkins job failed, comment |
/run-cpu-e2e |
@alexanderguzhva E2e jenkins job failed, comment |
rerun ut |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #31592 +/- ##
==========================================
+ Coverage 80.80% 80.90% +0.10%
==========================================
Files 965 960 -5
Lines 136613 138039 +1426
==========================================
+ Hits 110389 111685 +1296
- Misses 22508 22644 +136
+ Partials 3716 3710 -6
|
/run-cpu-e2e |
1 similar comment
/run-cpu-e2e |
Issue: #31285
pr: #30454
Basically, I've replaced FixedVector and boost::dynamic_bitset with custom bitset and bitsetview in order to reduce the memory bandwidth & increase performance for the filtering.
(cherry picked from commit 5dcecc8)