Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick] Custom bitset and bitset_view implementations #31592

Merged
merged 1 commit into from Mar 26, 2024

Conversation

alexanderguzhva
Copy link
Contributor

@alexanderguzhva alexanderguzhva commented Mar 25, 2024

Issue: #31285
pr: #30454

Basically, I've replaced FixedVector and boost::dynamic_bitset with custom bitset and bitsetview in order to reduce the memory bandwidth & increase performance for the filtering.

(cherry picked from commit 5dcecc8)

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
(cherry picked from commit 5dcecc8)
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Mar 25, 2024
Copy link
Contributor

mergify bot commented Mar 25, 2024

@alexanderguzhva Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Mar 25, 2024
@czs007
Copy link
Contributor

czs007 commented Mar 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 25, 2024

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

rerun ut

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 25, 2024

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 25, 2024

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

rerun ut

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 84.22713% with 400 lines in your changes are missing coverage. Please review.

Project coverage is 80.90%. Comparing base (f1a108c) to head (cb16997).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31592      +/-   ##
==========================================
+ Coverage   80.80%   80.90%   +0.10%     
==========================================
  Files         965      960       -5     
  Lines      136613   138039    +1426     
==========================================
+ Hits       110389   111685    +1296     
- Misses      22508    22644     +136     
+ Partials     3716     3710       -6     
Files Coverage Δ
internal/core/src/bitset/common.h 100.00% <100.00%> (ø)
internal/core/src/bitset/detail/bit_wise.h 100.00% <100.00%> (ø)
internal/core/src/bitset/detail/ctz.h 100.00% <100.00%> (ø)
...l/core/src/bitset/detail/platform/vectorized_ref.h 100.00% <100.00%> (ø)
...e/src/bitset/detail/platform/x86/instruction_set.h 76.47% <ø> (ø)
internal/core/src/bitset/detail/popcount.h 100.00% <100.00%> (ø)
internal/core/src/bitset/detail/proxy.h 100.00% <100.00%> (ø)
internal/core/src/common/BitsetView.h 87.50% <100.00%> (+0.83%) ⬆️
internal/core/src/common/Types.h 9.40% <ø> (+0.15%) ⬆️
internal/core/src/common/Vector.h 100.00% <100.00%> (ø)
... and 35 more

... and 195 files with indirect coverage changes

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 26, 2024
@sre-ci-robot sre-ci-robot merged commit 3addc68 into milvus-io:2.4 Mar 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants