Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support auto index for scalar index #31593

Merged
merged 1 commit into from Mar 27, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #29309
master pr: #31255

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/test sig/testing labels Mar 25, 2024
Copy link
Contributor

mergify bot commented Mar 25, 2024

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 80.82%. Comparing base (f1a108c) to head (c3258f1).
Report is 8 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31593      +/-   ##
==========================================
+ Coverage   80.80%   80.82%   +0.02%     
==========================================
  Files         965      969       +4     
  Lines      136613   136701      +88     
==========================================
+ Hits       110389   110489     +100     
+ Misses      22508    22500       -8     
+ Partials     3716     3712       -4     
Files Coverage Δ
internal/proxy/util.go 89.55% <ø> (-0.06%) ⬇️
pkg/util/indexparamcheck/conf_adapter_mgr.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/index_type.go 100.00% <ø> (ø)
pkg/util/indexparamcheck/inverted_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/scalar_index_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/stl_sort_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/trie_checker.go 100.00% <100.00%> (ø)
internal/proxy/task_index.go 77.18% <86.36%> (+2.35%) ⬆️
pkg/util/indexparamcheck/auto_index_checker.go 33.33% <33.33%> (ø)
pkg/util/paramtable/autoindex_param.go 89.06% <80.00%> (-4.92%) ⬇️

... and 23 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 25, 2024
@xiaocai2333 xiaocai2333 changed the title Support auto index for scalar index enhance: Support auto index for scalar index Mar 26, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed ci-passed do-not-merge/invalid-pr-format labels Mar 26, 2024
Copy link
Contributor

mergify bot commented Mar 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 27, 2024
@czs007
Copy link
Contributor

czs007 commented Mar 27, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b8f849e into milvus-io:2.4 Mar 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants