Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refactor hybrid search #31742

Merged
merged 1 commit into from Apr 9, 2024

Conversation

czs007
Copy link
Contributor

@czs007 czs007 commented Mar 29, 2024

issue: #25639 #31368
pr :#32020

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Mar 29, 2024

@czs007 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Mar 29, 2024

@czs007

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@czs007 czs007 changed the title Refactor hybrid search enhance: Refactor hybrid search Mar 29, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Mar 29, 2024
Copy link
Contributor

mergify bot commented Mar 29, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 force-pushed the merge_hybrid_2.4_v2 branch 2 times, most recently from eeb2bf0 to 036f889 Compare March 31, 2024 13:34
@zhagnlu
Copy link
Contributor

zhagnlu commented Apr 1, 2024

/lgtm

@samhuang-z
Copy link
Collaborator

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 2, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented Apr 2, 2024

/run-cpu-e2e

@czs007 czs007 force-pushed the merge_hybrid_2.4_v2 branch 3 times, most recently from d53c357 to f33b0a1 Compare April 3, 2024 09:12
Copy link
Contributor

mergify bot commented Apr 3, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor Author

czs007 commented Apr 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 3, 2024

@czs007 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 74.16667% with 217 lines in your changes are missing coverage. Please review.

Project coverage is 80.52%. Comparing base (3904719) to head (4740140).
Report is 24 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31742      +/-   ##
==========================================
- Coverage   80.89%   80.52%   -0.38%     
==========================================
  Files         964      973       +9     
  Lines      139422   138888     -534     
==========================================
- Hits       112791   111836     -955     
- Misses      22882    23300     +418     
- Partials     3749     3752       +3     
Files Coverage Δ
internal/distributed/querynode/client/client.go 92.71% <ø> (+1.76%) ⬆️
internal/distributed/querynode/service.go 81.01% <ø> (+0.74%) ⬆️
internal/proxy/impl.go 86.04% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/handlers.go 79.44% <100.00%> (+1.25%) ⬆️
internal/util/mock/grpc_querynode_client.go 76.00% <ø> (+2.92%) ⬆️
internal/util/wrappers/qn_wrapper.go 72.72% <ø> (-0.81%) ⬇️
internal/querynodev2/services.go 90.26% <75.00%> (+1.98%) ⬆️
internal/proxy/search_reduce_util.go 82.92% <86.13%> (+1.07%) ⬆️
internal/proxy/reScorer.go 70.86% <57.14%> (-5.38%) ⬇️
internal/querynodev2/delegator/delegator.go 89.68% <75.00%> (-2.59%) ⬇️
... and 3 more

... and 243 files with indirect coverage changes

@zhagnlu
Copy link
Contributor

zhagnlu commented Apr 7, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4c07304 into milvus-io:2.4 Apr 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants