enhance: [cherry-pick] Refine error message when search vector type not matched (#31725) #31766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvus-io#31725) Previously the error message only reports the case happened without field name and vector type. This PR add field name and vector type information in the error messages. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 1, 2024
See also milvus-io#31766 This PR add param place holder type check with search vector field type. This utility method also allows future float32, float16 and bfloat16 convertion. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #31766 +/- ##
==========================================
+ Coverage 80.81% 80.88% +0.07%
==========================================
Files 974 964 -10
Lines 138828 139186 +358
==========================================
+ Hits 112193 112587 +394
+ Misses 22873 22844 -29
+ Partials 3762 3755 -7
|
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 2, 2024
See also milvus-io#31766 This PR add param place holder type check with search vector field type. This utility method also allows future float32, float16 and bfloat16 convertion. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #31725
Previously the error message only reports the case happened without field name and vector type.
This PR add field name and vector type information in the error messages.