Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: update milvus.yaml #31832

Merged
merged 5 commits into from
Apr 16, 2024
Merged

enhance: update milvus.yaml #31832

merged 5 commits into from
Apr 16, 2024

Conversation

tedxu
Copy link
Collaborator

@tedxu tedxu commented Apr 2, 2024 •
edited

See #32168

@sre-ci-robot sre-ci-robot added do-not-merge/work-in-progress Don't merge even CI passed. size/XL Denotes a PR that changes 500-999 lines. labels Apr 2, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Apr 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024

@tedxu

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu tedxu force-pushed the enhance/update_config_file branch from 6351ea6 to 88388bc Compare April 11, 2024 03:31
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 11, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu tedxu force-pushed the enhance/update_config_file branch from 88388bc to 22ad3c8 Compare April 11, 2024 08:43
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 11, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu tedxu force-pushed the enhance/update_config_file branch from 22ad3c8 to 4f1d8c4 Compare April 11, 2024 09:36
@tedxu tedxu changed the title [WIP] enhance: update milvus.yaml enhance: update milvus.yaml Apr 11, 2024
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Apr 11, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue and removed do-not-merge/invalid-pr-format labels Apr 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 11, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 11, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor

aoiasd commented Apr 11, 2024

/lgtm

@tedxu tedxu force-pushed the enhance/update_config_file branch from 4f1d8c4 to 5a157df Compare April 12, 2024 03:09
@sre-ci-robot sre-ci-robot removed the lgtm label Apr 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@tedxu ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Collaborator Author

tedxu commented Apr 12, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Collaborator Author

tedxu commented Apr 12, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Apr 12, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (70e3d5b) to head (53bf2c5).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31832      +/-   ##
==========================================
+ Coverage   81.68%   81.73%   +0.04%     
==========================================
  Files         999      999              
  Lines      123915   123915              
==========================================
+ Hits       101218   101277      +59     
+ Misses      18819    18751      -68     
- Partials     3878     3887       +9
Files Coverage Δ
pkg/util/paramtable/autoindex_param.go 89.89% <ø> (ø)
pkg/util/paramtable/component_param.go 98.46% <100.00%> (ø)
pkg/util/paramtable/grpc_param.go 80.14% <100.00%> (ø)
pkg/util/paramtable/quota_param.go 73.74% <100.00%> (ø)
pkg/util/paramtable/service_param.go 98.12% <100.00%> (ø)

... and 23 files with indirect coverage changes

@tedxu tedxu force-pushed the enhance/update_config_file branch from 5be2c60 to ef8600f Compare April 15, 2024 04:20
yiwen92
yiwen92 reviewed Apr 15, 2024
View reviewed changes
configs/milvus.yaml

# Related configuration of queryCoord, used to manage topology and load balancing for the query nodes, and handoff from growing segments to sealed segments.
queryCoord:
taskMergeCap: 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any description or comments here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fill the descriptions in future PRs, thanks!

@tedxu
enhance: update milvus.yaml
987fcf3 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
adding a test to check file consistency
8244cec 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
Fixing lint checks
b8eb8dd 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
Adding more configuration entries
ad800ed 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
Fixing UT breaks
53bf2c5 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu force-pushed the enhance/update_config_file branch from ef8600f to 53bf2c5 Compare April 15, 2024 10:06
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 15, 2024

@tedxu ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Apr 15, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Apr 16, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 78d32bd into milvus-io:master Apr 16, 2024
15 checks passed
yiwen92
yiwen92 reviewed Apr 16, 2024
View reviewed changes
configs/milvus.yaml
server: # server side configuration for natsmq.
port: 4222 # 4222 by default, Port for nats server listening.
storeDir: /var/lib/milvus/nats # /var/lib/milvus/nats by default, directory to use for JetStream storage of nats.
maxFileStore: 17179869184 # (B) 16GB by default, Maximum size of the 'file' storage.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we choose to delete default value&unit in these params?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This is generated by code, code needs to add units&default value in future

@tedxu tedxu deleted the enhance/update_config_file branch April 23, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiwen92 yiwen92 yiwen92 left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@aoiasd aoiasd

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tedxu @aoiasd @congqixia @sre-ci-robot @yiwen92