Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Throw error instead of crash when index cannot be built #31845

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #27589
pr: #31844

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/compilation labels Apr 2, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Apr 2, 2024
Copy link
Contributor

mergify bot commented Apr 2, 2024

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Apr 2, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 changed the title Throw error instead of crash when index cannot be built enhance: Throw error instead of crash when index cannot be built Apr 3, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Apr 3, 2024
Copy link
Contributor

mergify bot commented Apr 3, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Copy link
Contributor

mergify bot commented Apr 3, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Apr 3, 2024
Copy link
Contributor

mergify bot commented Apr 3, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 3, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 24.19355% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 80.84%. Comparing base (8b8a5b4) to head (37acfbf).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31845      +/-   ##
==========================================
+ Coverage   80.62%   80.84%   +0.22%     
==========================================
  Files         973      974       +1     
  Lines      138980   139049      +69     
==========================================
+ Hits       112048   112414     +366     
+ Misses      23176    22889     -287     
+ Partials     3756     3746      -10     
Files Coverage Δ
pkg/util/merr/errors.go 85.71% <ø> (ø)
internal/util/indexcgowrapper/helper.go 59.32% <0.00%> (-3.18%) ⬇️
internal/indexnode/task_scheduler.go 87.01% <60.00%> (-0.41%) ⬇️
pkg/util/merr/utils.go 88.16% <0.00%> (-0.82%) ⬇️
internal/core/src/index/VectorMemIndex.cpp 38.69% <42.85%> (-0.01%) ⬇️
internal/core/src/index/VectorDiskIndex.cpp 58.13% <21.42%> (-2.03%) ⬇️
internal/core/src/indexbuilder/index_c.cpp 26.66% <0.00%> (-0.87%) ⬇️

... and 33 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Apr 3, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 3, 2024
@sre-ci-robot sre-ci-robot merged commit 3904719 into milvus-io:2.4 Apr 3, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants