Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Unify data type check APIs under internal/core #31857

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Apr 3, 2024

Issue: #22837 #31800

Move and rename following C++ APIs:
datatype_sizeof() ==> GetDataTypeSize()
datatype_name() ==> GetDataTypeName()
datatype_is_vector() / IsVectorType() ==> IsVectorDataType()
datatype_is_variable() ==> IsVariableDataType()
datatype_is_sparse_vector() ==> IsSparseFloatVectorDataType()
datatype_is_string() / IsString() ==> IsDataTypeString()
datatype_is_floating() / IsFloat() ==> IsDataTypeFloat()
datatype_is_binary() ==> IsDataTypeBinary()
datatype_is_json() ==> IsDataTypeJson()
datatype_is_array() ==> IsDataTypeArray()
datatype_is_variable() == IsDataTypeVariable()
datatype_is_integer() / IsIntegral() ==> IsDataTypeInteger()

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/compilation labels Apr 3, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Apr 3, 2024
Copy link
Contributor

mergify bot commented Apr 3, 2024

@cydrain Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 64.97175% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 80.64%. Comparing base (8b8a5b4) to head (b086bbe).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31857      +/-   ##
==========================================
+ Coverage   80.62%   80.64%   +0.02%     
==========================================
  Files         973      964       -9     
  Lines      138980   139356     +376     
==========================================
+ Hits       112048   112389     +341     
- Misses      23176    23206      +30     
- Partials     3756     3761       +5     
Files Coverage Δ
internal/core/src/common/Array.h 83.73% <100.00%> (-7.24%) ⬇️
internal/core/src/common/Schema.cpp 74.28% <100.00%> (+4.01%) ⬆️
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 88.44% <100.00%> (-3.50%) ⬇️
internal/core/src/index/IndexFactory.cpp 77.18% <100.00%> (+3.10%) ⬆️
internal/core/src/mmap/Column.h 91.42% <100.00%> (-0.28%) ⬇️
internal/core/src/mmap/Utils.h 80.00% <100.00%> (-3.88%) ⬇️
internal/core/src/query/SearchBruteForce.cpp 85.08% <100.00%> (+0.21%) ⬆️
internal/core/src/query/SearchOnGrowing.cpp 100.00% <100.00%> (ø)
internal/core/src/segcore/FieldIndexing.cpp 67.48% <100.00%> (-0.79%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.h 81.03% <100.00%> (+0.67%) ⬆️
... and 17 more

... and 202 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Apr 3, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cydrain cydrain added ci-passed manual-pass manually set pass before ci-passed labeled and removed do-not-merge/missing-related-pr labels Apr 3, 2024
@sre-ci-robot sre-ci-robot merged commit 76483b2 into milvus-io:2.4 Apr 3, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants