New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Unify data type check APIs under internal/core #31857
enhance: Unify data type check APIs under internal/core #31857
Conversation
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
@cydrain Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #31857 +/- ##
==========================================
+ Coverage 80.62% 80.64% +0.02%
==========================================
Files 973 964 -9
Lines 138980 139356 +376
==========================================
+ Hits 112048 112389 +341
- Misses 23176 23206 +30
- Partials 3756 3761 +5
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue: #22837 #31800
Move and rename following C++ APIs:
datatype_sizeof() ==> GetDataTypeSize()
datatype_name() ==> GetDataTypeName()
datatype_is_vector() / IsVectorType() ==> IsVectorDataType()
datatype_is_variable() ==> IsVariableDataType()
datatype_is_sparse_vector() ==> IsSparseFloatVectorDataType()
datatype_is_string() / IsString() ==> IsDataTypeString()
datatype_is_floating() / IsFloat() ==> IsDataTypeFloat()
datatype_is_binary() ==> IsDataTypeBinary()
datatype_is_json() ==> IsDataTypeJson()
datatype_is_array() ==> IsDataTypeArray()
datatype_is_variable() == IsDataTypeVariable()
datatype_is_integer() / IsIntegral() ==> IsDataTypeInteger()