Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add more metrics (#31271) #31861

Merged
merged 2 commits into from Apr 5, 2024
Merged

enhance: add more metrics (#31271) #31861

merged 2 commits into from Apr 5, 2024

Conversation

longjiquan
Copy link
Contributor

@longjiquan longjiquan commented Apr 3, 2024 •
edited

/kind improvement
fix: #31272
pr: #31271

This pr add more metrics, which are:

  • Slow query count, which the duration considered as slow can be configurable;
  • Number of deleted entities;
  • Number of entities imported;
  • Number of entities per collection;
  • Number of loaded entities per collection;
  • Number of indexed entities;
  • Number of indexed entities, per collection, per index and whether it's a vetor index;
  • Quota states (LongTimeTickDelay, MemoryExhuasted, DiskQuotaExhuasted) per database;

@longjiquan
enhance: add more metrics (milvus-io#31271)
7d760b7 
/kind improvement
fix: milvus-io#31272 

This pr add more metrics, which are:
- Slow query count, which the duration considered as slow can be
configurable;
- Number of deleted entities;
- Number of entities imported;
- Number of entities per collection;
- Number of loaded entities per collection;
- Number of indexed entities;
- Number of indexed entities, per collection, per index and whether it's
a vetor index;
- Quota states (LongTimeTickDelay, MemoryExhuasted, DiskQuotaExhuasted)
per database;

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/L Denotes a PR that changes 100-499 lines. labels Apr 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024

@longjiquan Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Apr 3, 2024
@longjiquan
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited

Codecov Report

Attention: Patch coverage is 83.14607% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 80.99%. Comparing base (3904719) to head (1f65a49).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31861      +/-   ##
==========================================
+ Coverage   80.89%   80.99%   +0.09%     
==========================================
  Files         964      964              
  Lines      139422   139588     +166     
==========================================
+ Hits       112791   113053     +262     
+ Misses      22882    22793      -89     
+ Partials     3749     3742       -7
Files Coverage Δ
internal/datacoord/import_scheduler.go 64.11% <100.00%> (+0.58%) ⬆️
internal/datacoord/meta.go 93.37% <100.00%> (+0.06%) ⬆️
internal/datacoord/metrics_info.go 94.68% <100.00%> (+1.13%) ⬆️
internal/datacoord/services.go 84.43% <100.00%> (+0.01%) ⬆️
pkg/metrics/datacoord_metrics.go 100.00% <100.00%> (ø)
pkg/metrics/metrics.go 100.00% <ø> (ø)
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)
pkg/metrics/rootcoord_metrics.go 100.00% <100.00%> (ø)
pkg/util/metricsinfo/metrics_info.go 100.00% <ø> (ø)
pkg/util/paramtable/component_param.go 98.36% <100.00%> (+<0.01%) ⬆️
... and 3 more

... and 36 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Apr 3, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b2a79a0 into milvus-io:2.4 Apr 5, 2024
14 checks passed
@longjiquan longjiquan deleted the 24-cp-31271 branch April 7, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@longjiquan @czs007 @sre-ci-robot