Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add some check fieldata dim (#31564) #31899

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Apr 3, 2024

issue: #30138
issue: #31724

pr: #31564

cqy123456 and others added 3 commits April 3, 2024 18:04
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 3, 2024
Copy link
Contributor

mergify bot commented Apr 3, 2024

@bigsheeper Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label Apr 3, 2024
Copy link
Contributor

mergify bot commented Apr 3, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added this to the 2.3.13 milestone Apr 3, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 3, 2024

/run-cpu-e2e

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper
Copy link
Contributor Author

rerun ut

@yanliang567
Copy link
Contributor

rerun failed tests

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bigsheeper
Copy link
Contributor Author

rerun ut

@czs007
Copy link
Contributor

czs007 commented Apr 4, 2024

@bigsheeper race detected

@bigsheeper
Copy link
Contributor Author

bigsheeper commented Apr 4, 2024

@bigsheeper race detected

2d4eeb42-5cf4-47fa-99b0-fb3666ee7a5f
@czs007 Doesn't relate to this pr, maybe we can merge dircetly.

@czs007 czs007 merged commit fa44753 into milvus-io:2.3 Apr 5, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants