Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove deprecated DataCoordNumStoredRowsCounter metric (#31778) #31935

Merged

Conversation

bigsheeper
Copy link
Contributor

pr: #31778

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (e3b6520) to head (b7f9f7c).
Report is 9 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31935      +/-   ##
==========================================
+ Coverage   80.62%   80.89%   +0.26%     
==========================================
  Files         976      976              
  Lines      139302   139298       -4     
==========================================
+ Hits       112319   112686     +367     
+ Misses      23223    22866     -357     
+ Partials     3760     3746      -14     
Files Coverage Δ
internal/datacoord/meta.go 93.35% <ø> (-0.02%) ⬇️
pkg/metrics/datacoord_metrics.go 100.00% <ø> (ø)

... and 39 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 7, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3df7f57 into milvus-io:2.4 Apr 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants