New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add channelCPs in FlushResponse #32044

Merged

sre-ci-robot merged 1 commit into milvus-io:master from wayblink:cdc-dev

Apr 30, 2024

Contributor

wayblink commented Apr 9, 2024 •

edited

sre-ci-robot added the size/M label

sre-ci-robot requested review from congqixia, cydrain and czs007

April 9, 2024 03:37

sre-ci-robot added the area/dependency label

mergify bot added dco-passed do-not-merge/invalid-pr-format labels

Contributor

mergify bot commented Apr 9, 2024

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

Title Format: The PR title must begin with one of these prefixes:

feat: for introducing a new feature.
fix: for bug fixes.
enhance: for improvements to existing functionality.
test: for add tests to existing functionality.
doc: for modifying documentation.
auto: for the pull request from bot.

Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

Contributor

mergify bot commented Apr 9, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from b75e91e to 70b91a5 Compare

April 9, 2024 06:42

Contributor

mergify bot commented Apr 9, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from 70b91a5 to 707a36f Compare

April 9, 2024 09:11

Contributor

mergify bot commented Apr 9, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from 707a36f to 4b97658 Compare

April 9, 2024 11:32

sre-ci-robot added size/L and removed size/M labels

Contributor

mergify bot commented Apr 9, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from 4b97658 to cf0635e Compare

April 10, 2024 02:46

Contributor

mergify bot commented Apr 10, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from cf0635e to 7049391 Compare

April 10, 2024 07:17

Contributor

mergify bot commented Apr 10, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

Contributor

mergify bot commented Apr 10, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from 7049391 to 2e72dec Compare

April 10, 2024 12:31

Contributor

mergify bot commented Apr 10, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from 2e72dec to 02ffbe3 Compare

April 11, 2024 02:17

Contributor

mergify bot commented Apr 11, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Apr 11, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

wayblink force-pushed the cdc-dev branch from 02ffbe3 to 2853442 Compare

April 11, 2024 03:56

Contributor

mergify bot commented Apr 11, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from 2853442 to cafcba5 Compare

April 11, 2024 06:34

Contributor

mergify bot commented Apr 26, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from 7f9fdb5 to c074a65 Compare

April 28, 2024 02:41

Contributor

mergify bot commented Apr 28, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from c074a65 to fde0924 Compare

April 28, 2024 07:03

Contributor

mergify bot commented Apr 28, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor Author

wayblink commented Apr 28, 2024

rerun ut

Contributor Author

wayblink commented Apr 28, 2024

/run-cpu-e2e

yanliang567 added this to the 2.4.1 milestone

Contributor

mergify bot commented Apr 28, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch from fde0924 to d95f903 Compare

April 28, 2024 11:38

Contributor

mergify bot commented Apr 28, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink changed the title ~~Add channelCPs in FlushResponse~~ enhance: Add channelCPs in FlushResponse

mergify bot added kind/enhancement and removed do-not-merge/invalid-pr-format labels

Contributor

mergify bot commented Apr 28, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the cdc-dev branch 3 times, most recently from 955a318 to 69431e9 Compare

April 29, 2024 10:02

Contributor

mergify bot commented Apr 29, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Apr 29, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.


          Add channelCPs in FlushResponse

26a0832

Signed-off-by: wayblink <anyang.wang@zilliz.com>

wayblink force-pushed the cdc-dev branch from 69431e9 to 26a0832 Compare

April 29, 2024 12:51

mergify bot added the ci-passed label

Contributor

czs007 commented Apr 30, 2024

/approve
/lgtm

sre-ci-robot assigned czs007

sre-ci-robot added the lgtm label

Contributor

sre-ci-robot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot added the approved label

sre-ci-robot merged commit 42d0412 into milvus-io:master

15 checks passed

czs007 mentioned this pull request

enhance: Add channelCPs in FlushResponse #32683

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bigsheeper bigsheeper left review comments

XuanYang-cn XuanYang-cn approved these changes

congqixia Awaiting requested review from congqixia

cydrain Awaiting requested review from cydrain

czs007 Awaiting requested review from czs007