Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support disable search optimization #32141

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

chasingegg
Copy link
Contributor

No description provided.

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 10, 2024
Copy link
Contributor

mergify bot commented Apr 10, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (25a1c9e) to head (a1d73fc).
Report is 50 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32141      +/-   ##
==========================================
+ Coverage   81.68%   81.77%   +0.09%     
==========================================
  Files         990      990              
  Lines      121671   122108     +437     
==========================================
+ Hits        99382    99857     +475     
+ Misses      18484    18442      -42     
- Partials     3805     3809       +4     
Files Coverage Δ
internal/querynodev2/optimizers/query_hook.go 86.04% <100.00%> (ø)

... and 71 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 11, 2024
sre-ci-robot pushed a commit that referenced this pull request Apr 15, 2024
pr: #32141

---------

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Apr 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 55d894b into milvus-io:master Apr 16, 2024
15 checks passed
@chasingegg chasingegg deleted the autoindex-update branch April 16, 2024 03:25
czs007 pushed a commit that referenced this pull request Apr 17, 2024
master pr: #32141
2.4 pr: #32142

Signed-off-by: chasingegg <chao.gao@zilliz.com>
samhuang-z pushed a commit to samhuang-z/milvus that referenced this pull request Apr 18, 2024
pr: milvus-io#32141

---------

Signed-off-by: chasingegg <chao.gao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants