Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix collectionInfo leak in datacoord #32243

Merged
merged 2 commits into from Apr 15, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #32029
pr: #32175

lack of logic to clean collection info in datacoord's meta, This PR clean collection info after drop channel, to avoid collection info leak in datacoord

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 14, 2024
Copy link
Contributor

mergify bot commented Apr 14, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 14, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.56%. Comparing base (5f7edc7) to head (794185c).
Report is 9 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32243      +/-   ##
==========================================
- Coverage   81.65%   81.56%   -0.09%     
==========================================
  Files         966      976      +10     
  Lines      120188   119977     -211     
==========================================
- Hits        98135    97858     -277     
- Misses      18325    18372      +47     
- Partials     3728     3747      +19     
Files Coverage Δ
internal/datacoord/handler.go 83.19% <100.00%> (ø)
internal/datacoord/meta.go 94.15% <100.00%> (ø)
internal/rootcoord/quota_center.go 90.49% <100.00%> (ø)
internal/datacoord/channel_manager.go 79.34% <0.00%> (ø)

... and 208 files with indirect coverage changes

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@czs007 czs007 added this to the 2.4.0 milestone Apr 15, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 15, 2024
@tedxu
Copy link
Collaborator

tedxu commented Apr 15, 2024

/lgtm

@tedxu
Copy link
Collaborator

tedxu commented Apr 15, 2024

/approve

1 similar comment
@czs007
Copy link
Contributor

czs007 commented Apr 15, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, tedxu, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2726d63 into milvus-io:2.4 Apr 15, 2024
14 of 15 checks passed
samhuang-z pushed a commit to samhuang-z/milvus that referenced this pull request Apr 18, 2024
issue: milvus-io#32029
pr: milvus-io#32175 

lack of logic to clean collection info in datacoord's meta, This PR
clean collection info after drop channel, to avoid collection info leak
in datacoord

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants