Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: reduce the cpu usage when collection number is high #32245

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

xiaofan-luan
Copy link
Contributor

related to #32165

  1. for all the manager, support collection level index
  2. remove collection level filter to avoid extra cpu usage when collection number increases

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 14, 2024
Copy link
Contributor

mergify bot commented Apr 14, 2024

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 14, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 15, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (b287fba) to head (cb1da1d).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32245      +/-   ##
==========================================
- Coverage   81.73%   81.72%   -0.01%     
==========================================
  Files        1000     1000              
  Lines      124377   124430      +53     
==========================================
+ Hits       101657   101691      +34     
- Misses      18844    18864      +20     
+ Partials     3876     3875       -1     
Files Coverage Δ
...al/querycoordv2/balance/rowcount_based_balancer.go 97.73% <100.00%> (ø)
internal/querycoordv2/checkers/channel_checker.go 84.55% <100.00%> (ø)
internal/querycoordv2/job/utils.go 86.76% <100.00%> (+1.28%) ⬆️
internal/querycoordv2/meta/channel_dist_manager.go 96.38% <100.00%> (+1.22%) ⬆️
...nternal/querycoordv2/observers/replica_observer.go 95.23% <100.00%> (ø)
...ternal/querycoordv2/observers/resource_observer.go 94.44% <100.00%> (ø)
internal/querycoordv2/ops_services.go 83.15% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.42% <100.00%> (ø)
internal/querycoordv2/balance/utils.go 47.58% <0.00%> (ø)

... and 38 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Apr 16, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 16, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 16, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 16, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 16, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 16, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 18, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 18, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 19, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan xiaofan-luan force-pushed the ImproveMetaSpeed branch 3 times, most recently from 30f7b49 to f336994 Compare April 25, 2024 04:41
Copy link
Contributor

mergify bot commented Apr 25, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 25, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 25, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Apr 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 02ace25 into milvus-io:master Apr 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants