Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: make the auth error message more suitable #32253

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Apr 15, 2024

/issue: #32252
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Apr 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 15, 2024
Copy link
Contributor

mergify bot commented Apr 15, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Apr 15, 2024

/run-cpu-e2e

@SimFG
Copy link
Contributor Author

SimFG commented Apr 15, 2024

rerun ut

Copy link
Contributor

mergify bot commented Apr 15, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.70%. Comparing base (ab6ddf6) to head (dce583f).
Report is 27 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #32253    +/-   ##
========================================
  Coverage   81.69%   81.70%            
========================================
  Files         997      999     +2     
  Lines      123431   123903   +472     
========================================
+ Hits       100839   101233   +394     
- Misses      18727    18799    +72     
- Partials     3865     3871     +6     
Files Coverage Δ
internal/proxy/authentication_interceptor.go 95.91% <100.00%> (ø)
internal/proxy/privilege_interceptor.go 75.00% <100.00%> (ø)
pkg/util/constant.go 93.33% <ø> (ø)
pkg/util/contextutil/context_util.go 76.47% <80.00%> (ø)

... and 30 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented Apr 15, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 15, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Apr 16, 2024

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented Apr 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 84f05ba into milvus-io:master Apr 16, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Apr 16, 2024
issue: #32252
pr: #32253
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
samhuang-z pushed a commit to samhuang-z/milvus that referenced this pull request Apr 18, 2024
…2298)

issue: milvus-io#32252
pr: milvus-io#32253
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants